Add SCRAM-SHA-256 authentication to this library #833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bump |
This was referenced Apr 9, 2019
|
@mjibson ping? That PR looks like be based on current master and so nothing prevent it from merging. |
|
We're entering the no tests yolo phase of lib/pq. But since this didn't touch any other auth methods, I'll just assume one of you tested that it works. If someone wants I'd merge a test for this. |
|
Yeah, at least, it was me, who checked it and, well, it connects, authenticates and looks like works fine |
|
@mjibson thanks for merging. did you look at the other PRs implementing it with tests? |
|
When I looked those PRs weren't click-mergable, which is what I was looking for. If someone wants to port the tests from the other PRs I'll merge those, but I'm probably not going to do that myself. |
This was referenced Mar 13, 2020
4 tasks
|
Please note that there were several PRs for this point... |
This was referenced Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes add SCRAM-SHA-256 authentication to the pq library, by adding a slightly modified version of the mgo scram library and implementing it's functionality in the auth section of conn.go.